fix(dashboard): clean error when model record lacks gguf_file - #2920
Open
patil2001 wants to merge 1 commit into
Open
fix(dashboard): clean error when model record lacks gguf_file#2920patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
A persisted model-library record with an id but no gguf_file raised an unhandled KeyError on download/delete, surfacing as a 500. These paths now read gguf_file via .get() and return a clean 404 when it is missing, matching the sibling .get()-based access used elsewhere in the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A persisted model-library record with an id but no gguf_file raised an
unhandled KeyError on download/delete, surfacing as a 500. These paths
now read gguf_file via .get() and return a clean 404 when it is missing,
matching the sibling .get()-based access used elsewhere in the module.
AI Assistance
AI-assisted draft; human reviewed the diff and chose the validation below.
Release Lane
release/2.6.xmainChanged Surface
Risk And Validation
git diff --checkCommands/results:
Operational Change Check